Change loop index from float to int#4784
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Nov 9, 2020
bd0n4lds:Dont-Use-Float-Type-For-Loop-Indices
Merged
Change loop index from float to int#4784Stypox merged 1 commit intoTeamNewPipe:devfrom bd0n4lds:Dont-Use-Float-Type-For-Loop-Indices
Stypox merged 1 commit intoTeamNewPipe:devfrom
bd0n4lds:Dont-Use-Float-Type-For-Loop-Indices
Conversation
Member
|
I don't think that is how it should be handled. This just looks wrong. |
Author
|
Redid the casting on the for loop indices and changed back the variable mMarqueeProgress to float. |
Contributor
|
why is |
Author
Made the change |
Member
|
looks okay now. Please squash your commits. |
Stypox
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Codacy found issues "Don't use floating point for loop indices. If you must use floating-point, use double."
Fixes the following issue(s)
Relies on the following changes
APK testing
debug.zip
Due diligence